Refactor ScaleDownSet processor into a composite processor #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
kawych
force-pushed
the
composite_proc
branch
from
5407ba1 to
ea94a2b
Compare
|
/lgtm Thanks for making the change! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kawych, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
towca
reviewed
Sep 13, 2023
| @@ -178,7 +178,10 @@ func NewTestProcessors(context *context.AutoscalingContext) *processors.Autoscal | |||
| NodeGroupListProcessor: &nodegroups.NoOpNodeGroupListProcessor{}, | |||
| BinpackingLimiter: binpacking.NewDefaultBinpackingLimiter(), | |||
| NodeGroupSetProcessor: nodegroupset.NewDefaultNodeGroupSetProcessor([]string{}, config.NodeGroupDifferenceRatios{}), | |||
| ScaleDownSetProcessor: nodes.NewPostFilteringScaleDownNodeProcessor(), | |||
| ScaleDownSetProcessor: nodes.NewCompositeScaleDownSetProcessor([]nodes.ScaleDownSetProcessor{ | |||
There was a problem hiding this comment.
Oops, missed this: why is the order different for test processors? Was this intended? I think we always want to call the max nodes one first so that we avoid breaking the atomic property (could be worth capturing that in a comment somewhere btw)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Split ScaleDownSet processor into two processors doing their individual tasks. This allows more flexibility when overriding these processors, such as adding another targeted processor to the pipeline, or removing one of the processors if it's not needed.
Special notes for your reviewer:
CC @towca
Does this PR introduce a user-facing change?